Randomising missions

[Octocat]

More concise and economical way to generate random numbers:

internal ISectionFile RandomiseMission()
{
    var random = new Random(Environment.TickCount);

    ...
    value = random.Next(minBreezeActivity, maxBreezeActivity).ToString();

    ...
    value = random.Next(minThermalActivity, maxThermalActivity).ToString();

    ...
}

[salmo]

Originally Posted by Octocat

More concise and economical way to generate random numbers:

code removed by author

It's a moot point. The random method certainly uses less resources & therefore is "more efficient", but many argue about the "randomness" of the numbers generated. The Cryptography system method uses more resources, but provides a "better" (more unpredictable) random number set. Of course, to get true randon numbers you would have to seed the generator with something truely random such as cosmic radiation or background noise.

[Octocat]

Here the main idea: do not create an object of Random anew for each use. One would be enough.

[salmo]

Originally Posted by Octocat

Here the main idea: do not create an object of Random anew for each use. One would be enough.

So are you saying that the NextInt routine would be better if the highlighted line were used?

code removed by author

[Octocat]

No, code "return Random(result).Next(min, max);" is syntactic error for C# compiler, because keyword new required.

I saying, you can remove NextInt function completely. Then create single instance of Random class in the RandomizeWeather function, and then use it as many times as you like, as in my example above.

[Octocat]

The random method certainly uses less resources...

Random in not the method, but class.

Line below creates instance of Random class, and assigns the value to variable named random.

var random = new Random(Environment.TickCount);

Now, we can call method "Next" any number of times:

int randomNumber = random.Next(min, max);

[salmo]

Thankyou Octocat. I known how random.next works, but I chose to go with the RNGCryptoServiceProvider rather than the Random class because I feel it gives me "better" random numbers. Anyone using the script is welcome to replace the NextInt routine with the random class as suggested.