Bugfixes

[messiahgov]

A quick feedback to the fixes from the 1st post.

The following bugs are still unfixed in WotN v1.3.1.6250. For them, I used the recommended fixes from the 1st post.

- Sense Weakness fix
- Soothsayer Ice Storm fix
- Trolls Pacify fix
- Ice Prison/Hilda's Arrows fix
- Mista's Lightning fix

The examples from the 1st post can all be found, so they're are still not fixed officially.

==============================

The following bugs/fixes are unclear (at least for me) in WotN v1.3.1.6250.

- Highterant fix

Seems like it got fixed or at least changed, because the coderange/example of code from Bhruic is not the same anymore, just parts of it.

==============================

- Various warning fixes

This fix is unclear, too many locations to change and the example is too inaccurate to determine the right spots.

Example:

Should this (line 4242):

  if table.getn(targets_1) == 0 then
    Game.InvokeMsgBox("warning", "<label=sw_default>")
    Attack.log_label("null")
    return false
  else

Or this (line 5805):

  if ccnt == 0 then
    Game.InvokeMsgBox("warning","<label=no_place_to_fall>")
    Attack.log_label("null")
    return false
  else

Or this (line 6664, seem to be fixed already):

if not need_res then
	if not Attack.is_computer_move() then
	Game.InvokeMsgBox("warning", "<label=sw_default>")
	return true
	end

..be changed? There are many more locations, that are just examples. They are not equal at all and some might be already fixed and maybe those fixed ones are all that need to be fixed. I'm not sure.

==============================

- Fear (partial?) fix

Maybe it's already fixed.

This:

if h > max_hazard then
	max_hazard = h
	target = act
	prob = k * (1 + hit_count*0.5)
end

Became this (official):

if h > max_hazard then
    offencive_attack = true
    max_hazard = h
    target = act
    prob = k * (1 + hit_count*0.5)
end

==============================

- Blizzard fix

Maybe it's already fixed?

This:

effect_freeze_attack(cell_found, t_shift, 3, nil, 1)

Became this (now line 6603, official):

effect_freeze_attack(cell, dmgtsi, 3, nil, 1)