Bugfixes

[Bhruic]

I managed to get to it as an ice dragon, but that's almost certainly a fix that 1C will have to do. The "use" option details in the items.txt file is just a string of hex numbers which, without knowing what they correspond to, are virtually impossible to decipher.

[rekiem]

O well, that's a pity, no early Ice Dragon for me then hah, thanks alot for trying, and for all the other bugfixes

[Bhruic]

Haha, I just spent a fruitless 30 minutes (and why I'm laughing about that I don't know! ). I went back to playing, and noticed that enemies were getting hit with something called "Fatal luck", which put some random curse on them. I thought, "uh oh, I must have messed something up in the code somewhere". So I went back and kept tinkering with things to figure out what I'd done wrong.

Well, long story short, it turns out I had the "Chain of Chance" on, which - apparently - hits an enemy with a curse any time they hit you with a critical hit. The description is horribly wrong, saying just that it "curses enemies, inflicting critical strikes". What it really does is curse enemies when you get hit with a critical strike. Of course I hadn't seen it yet, as the enemy never critical struck anyone thanks to the bug.

[camelotcrusade]

Good work as always. Been updating the bug thread with the fixes. A few quick questions.

1. Can you add the alchemist/engineer fix to the main page? The description really does say they should mix 1-2 bottles and doesn't mention the toolkit, so I think it's a legit fix and not just a mod.
2. Love that you fixed spell/rage crit. What skill or ability gives you rage crit that's not working? I want to list the fix near the bug (and I don't even know if I have that bugged yet).
3. I'll add the new bug you just mentioned. Is Chain of Chance an item?
4. Got any time to wade into the necromancer/shackles issue? It's a puzzler.

[Bhruic]

1) I'm still on the fence on that one. Yes, the tooltip says 1-2, but the tooltips are frequently wrong in the game, as you well know . Plus, there's no indication of what the chance of a second one should be, if in fact you are supposed to get 1-2. Should it be a 50-50 split?

2) Icy Rage is the skill that increases your critical hit chance for Rage, but it should be pointed out that you always should have a chance to crit with Spells/Rage attacks. The probability seems quite low (unless they have Doom cast on them, which guaruntees a crit with anything). If I'm reading this right, the base probability is:
3 x (current mana-or-rage / maximum mana-or-rage).

3) It's not really a bug, it's just a side-effect of fixing the critical hit bug. It required one of my units to take a critical hit to activate, which never happened (because of the bug). Now that it's fixed, it does happen, which took me by surprise.

4) I've read about it, but I haven't got that spell yet, so I haven't tried using in on various undead. Maybe I'll cheat and give it to myself to see what's up.

[camelotcrusade]

Thanks very much sir. Once they release the first patch we can go about noting what's fixed and separating the mods from the bugs if some of their intentions get clarified. I am fond of the alchemist fix and the song of alfheim fix, but like you said you never know what they are doing to do (if they even change them). Or if you have time we know this is coming so you could make an optional fixes/mods section.

I added Chain of Chance to description bugs since it lies.

[Zechnophobe]

Originally Posted by Bhruic

1) I'm still on the fence on that one. Yes, the tooltip says 1-2, but the tooltips are frequently wrong in the game, as you well know . Plus, there's no indication of what the chance of a second one should be, if in fact you are supposed to get 1-2. Should it be a 50-50 split?

In KBAP it was ~33% chance of two, by my eyeballing of it. (I used Alchemists with 4 movement for a run. They were like little no-retaliation poison dealing land dragons!)

2) Icy Rage is the skill that increases your critical hit chance for Rage, but it should be pointed out that you always should have a chance to crit with Spells/Rage attacks. The probability seems quite low (unless they have Doom cast on them, which guaruntees a crit with anything). If I'm reading this right, the base probability is:
3 x (current mana-or-rage / maximum mana-or-rage).

Now that is interesting. That sounds like it's about one tenth the intended strength, even when working correctly. Having a 3% crit chance when at max rage or mana is very minor. But I really dig the intention at least. Makes mana regen to keep yourself topped off feel a bit more important.

3) It's not really a bug, it's just a side-effect of fixing the critical hit bug. It required one of my units to take a critical hit to activate, which never happened (because of the bug). Now that it's fixed, it does happen, which took me by surprise.

Hmm, I'll have to fix the description on this one when I get to items. This was a CW item that had the same effect, and was similarly difficult to understand then!

4) I've read about it, but I haven't got that spell yet, so I haven't tried using in on various undead. Maybe I'll cheat and give it to myself to see what's up.

If I remember, I'll at least try to reproduce the bug when I get home from work.

[Bhruic]

Well, I made a test game to check out the Magic Shackles bug, it seems like I can affect all other undead except the Necromancers, so it can't be the mind immunity. Definitely isn't a leadership problem either, as I found a stack with a single one.

Weirdly, there doesn't seem to be a txt file for units, so I can't check to see if it's going something extra set that would be blocking the spell.

[camelotcrusade]

Originally Posted by Bhruic

1) If I'm reading this right, the base probability is:
3 x (current mana-or-rage / maximum mana-or-rage).

Any idea how crit bonus skills are applied now that crits are working? I think it was +3/5/7% (maybe, I'd have to check again) and I wonder if they multiplicative or additive. If they aren't additive then you really don't get much out of them... especially if you don't start with enough mana to begin with.

[Bhruic]

They are additive.

I should also point out that unlike regular crits, the crit increase isn't a static 1.5, but is 1.3 + 0.4 x (previous formula from above).