elves are considered to be some of the best units in the games, but not as good as demons. And she gives them a bonus.
In 1.6.4 and earlier she is bugged and can't have children no matter how often you try. Which is good probably since children tend to suck compared to items.
I don't like the whole divorcing thing... I would have been ok with a harem but kicking the wife and children out just seems so wrong to do

... If you are interested in role playing a good character she could be the right wife for you because:
1. Demons = bad
2. Zombie = bad
3. Pirate = bad
4. Frog princess gives birth to horrible monstrosities.
Well... that makes her the ideal wife for RP purposes for some. But the question was about the quality of her bonuses...